Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(clerk-js): Add support for combined flow in buildUrl #4626

Merged
merged 8 commits into from
Nov 25, 2024
Merged

feat(clerk-js): Add support for combined flow in buildUrl #4626

merged 8 commits into from
Nov 25, 2024

Conversation

alexcarpenter
Copy link
Member

@alexcarpenter alexcarpenter commented Nov 21, 2024 •
edited
Loading

Description

Add logic to buildUrl helper for combined flows. When in combinedFlow update to point to the sign-in#/create route to render the sign-up flow.

  • Handles ticket flow
  • handles SignUpButton routing
  • Handles buildUrl functionality

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@vercel Vercel
Copy link

vercel bot commented Nov 21, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
clerk-js-sandbox ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 22, 2024 8:27pm

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 21, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: a4f9a44

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@alexcarpenter alexcarpenter marked this pull request as ready for review November 21, 2024 17:26
@alexcarpenter alexcarpenter marked this pull request as draft November 21, 2024 18:05
@alexcarpenter alexcarpenter marked this pull request as ready for review November 21, 2024 23:12
@alexcarpenter alexcarpenter merged commit 0bf9516 into alexcarpenter/sign-in-up-flow-init Nov 25, 2024
6 checks passed
@alexcarpenter alexcarpenter deleted the alexcarpenter/sdki-757-buildurls branch November 25, 2024 16:22
@alexcarpenter alexcarpenter mentioned this pull request Nov 25, 2024
Open
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BRKalow BRKalow Awaiting requested review from BRKalow

Assignees
No one assigned
Labels
clerk-js types
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexcarpenter @BRKalow @clerk-cookie